Angular: Configuration Components Deprecation Warning #31511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a deprecation warning system for legacy nested configuration components in the DevExtreme Angular wrapper. The implementation detects when developers use generic legacy nested components (like dxi-item, dxo-animation) and warns them to upgrade to component-specific variants (like dxi-accordion-item, dxo-accordion-animation).
Key changes:
- New deprecation warning utility that detects legacy nested component usage and suggests modern replacements
- Integration of the warning system into the nested option lifecycle
- Comprehensive mapping of legacy to modern selectors across all DevExtreme components
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme-angular/src/core/nested-option.ts |
Added import and integration of the deprecation warning into NestedOptionHost.setNestedOption() |
packages/devextreme-angular/src/core/deprecated-config-warning.ts |
New file implementing the deprecation warning logic with class name parsing, host component detection, and console warning emission |
packages/devextreme-angular/src/core/deprecated-config-map.ts |
New generated file containing mappings from host components to their legacy/modern nested component selector pairs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.